Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update furniture-sleep.json #64236

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

dgreenlee1
Copy link
Contributor

Summary

Bugfixes "Straw Beds give more straw piles when deconstructed, up to 80%-90% of required instead of just 5%"

Purpose of change

This change Fixes #64227, a pile of straw is an amorphous mass that doesn't spill or become destroyed by forming it into different shapes such as a bedroll. When a straw bed is deconstructed, it should give back just about as much straw as was needed to make it. And it also makes more sense if carefully deconstructing the bed returns more materials than bashing it apart.

Describe the solution

I made it give more straw instead of less in the .json file in the data folder.

Describe alternatives you've considered

I also considered adjusting the amount of straw returned by bashing the bed apart, but that would be outside the scope of this change.

Testing

Making a straw bed and deconstructing it returns materials.

Additional context

N/A

Modified "deconstruct" to return more "straw_pile" items, per Issue CleverRaven#64227 - "Straw Beds Give Just 5% of its Straw on Deconstruction"
@github-actions
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 13, 2023
@PatrikLundell
Copy link
Contributor

PatrikLundell commented Mar 14, 2023

Straw does "spill" in the form of individual straws getting lost, and gets destroyed by straws breaking into smaller pieces with use. Thus, getting most of it, but not all, back seems reasonable.

Also, the title isn't ideal. It's better to say what you're trying to achieve with a PR, rather than just say which file it has modified. I don't think it's critical for this PR, but might be useful for future ones.

@SolventMercury
Copy link
Contributor

Straw does "spill" in the form of individual straws getting lost, and gets destroyed by straws breaking into smaller pieces with use. Thus, getting most of it, but not all, back seems reasonable.

The current changes appear to already incorporate this - giving a variable amount of straw rather than the exact amount that went in.

@PatrikLundell
Copy link
Contributor

Yes. My comment was on the text part of the PR which sort of says that there shouldn't be any losses. The second sentence was intended to state that I did agree with the implementation which does allow for some losses.

Thus, I think it's simply a minor matter of miscommunication.

@flybye3o6
Copy link
Contributor

flybye3o6 commented Mar 14, 2023

also make sure you make a new "branch" under your "dgreenlee1:master" branch, so you can work on multiple projects at the same time

@bombasticSlacks bombasticSlacks merged commit 735cf64 into CleverRaven:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Straw Beds Give Just 5% of its Straw on Deconstruction
5 participants