-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update furniture-sleep.json #64236
Update furniture-sleep.json #64236
Conversation
Modified "deconstruct" to return more "straw_pile" items, per Issue CleverRaven#64227 - "Straw Beds Give Just 5% of its Straw on Deconstruction"
Update furniture-sleep.json
You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
Straw does "spill" in the form of individual straws getting lost, and gets destroyed by straws breaking into smaller pieces with use. Thus, getting most of it, but not all, back seems reasonable. Also, the title isn't ideal. It's better to say what you're trying to achieve with a PR, rather than just say which file it has modified. I don't think it's critical for this PR, but might be useful for future ones. |
The current changes appear to already incorporate this - giving a variable amount of straw rather than the exact amount that went in. |
Yes. My comment was on the text part of the PR which sort of says that there shouldn't be any losses. The second sentence was intended to state that I did agree with the implementation which does allow for some losses. Thus, I think it's simply a minor matter of miscommunication. |
also make sure you make a new "branch" under your "dgreenlee1:master" branch, so you can work on multiple projects at the same time |
Summary
Bugfixes "Straw Beds give more straw piles when deconstructed, up to 80%-90% of required instead of just 5%"
Purpose of change
This change Fixes #64227, a pile of straw is an amorphous mass that doesn't spill or become destroyed by forming it into different shapes such as a bedroll. When a straw bed is deconstructed, it should give back just about as much straw as was needed to make it. And it also makes more sense if carefully deconstructing the bed returns more materials than bashing it apart.
Describe the solution
I made it give more straw instead of less in the .json file in the data folder.
Describe alternatives you've considered
I also considered adjusting the amount of straw returned by bashing the bed apart, but that would be outside the scope of this change.
Testing
Making a straw bed and deconstructing it returns materials.
Additional context
N/A