Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electric-jackhammer-power-tweaks #64182

Merged

Conversation

flybye3o6
Copy link
Contributor

Summary

Balance "tweaks to electric jackhammer's power costs"

Purpose of change

a few constructions had there fuel cost set to 50 for both gas and electric jackhammers set out to find what the ratio for fuel cost should be for the 2 jackhammers

Describe the solution

the gasoline one seemed to be spot on so used that as the baseline
used a 2200w electric jackhammer common for demolition and construction for its stats
adjusted the power cost based on the gas powered one at a ratio of 5gas/66kj
set its battery capacity to 1 hour use and adjusted its action to 30min use same as the gas powered one

Describe alternatives you've considered

could set the max stored power to the same as the medium storage battery used in its crafting

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 12, 2023
@RAldrich
Copy link
Contributor

Would it make sense to eliminate the UPS from this and make it run on regular batteries while you're at it?

UPS is pretty archaic and is only used by this jackhammer, smartphones, and the combat exoskeletons. It makes no sense to have a wirelessly rechargable jackhammer.

@flybye3o6
Copy link
Contributor Author

Would it make sense to eliminate the UPS from this and make it run on regular batteries while you're at it?

thats out of the scope of this PR, but ill keep it in mind
i did do a bit of research and there are cordless electric jackhammers but they are not great or common
something i wanted to do is have the electric jackhammer 26kg you can find be corded needing a power grid to plug into
(people were asking for the ability for extension cords to plug into electric items in your inventory and plug into a grid so ill wait for that (if possible))
and a craft to have a makeshift modification to add a swappable power pack but have some draw backs (less efficiency, more weight and volume)
also there are smaller electric jackhammers 10kg i could add and use heavy tool batteries, they are not rated for much but they could be used to break locks and light crafting, they wouldnt be able to take down a concert wall in 30mins and only have enough power for about 15mins

@RAldrich
Copy link
Contributor

Sounds good.

If we get functionality for cords plugging into things, that should let us get rid of UPS entirely. My understanding is that UPS was originally created in large part because it was hard to design a system for "what is plugged into what" in inventory, and it was easier to have a magic power field that just recharges everything you're holding.

@kevingranade kevingranade merged commit cf21986 into CleverRaven:master Mar 14, 2023
@MoonlitRiverlight
Copy link

Battery jackhammers rely on having other batteries in rechargers and rotating them as you empty the one currently in the machine. They're not meant to do a huge contruction work in a single battery load. This might be a moot point for us since UPS is leaving at some point, but the interrupted construction system could be used to reflect the irl case. Do the battery load, get x% done, swap the batteries, continue.

@flybye3o6 flybye3o6 deleted the electric-jackhammer-tweaks branch March 16, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants