item_location: add a parent_pocket() helper #64178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei8l
force-pushed
the
inv_ui-faster-is_hidden
branch
from
b0c79b4 to
5d51407
Compare
github-actions
bot
added
[C++]
andrei8l
force-pushed
the
inv_ui-faster-is_hidden
branch
from
5d51407 to
4226c80
Compare
that caches the parent pocket so you don't have to run contained_where() everytime
andrei8l
force-pushed
the
inv_ui-faster-is_hidden
branch
from
4226c80 to
504ba4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Squeeze some more performance out of the inventory UI for the very common case of containers with only one pocket.
Describe the solution
Add an
item_location::parent_pocket()helper that caches the parent pocket and uses a shortcut instead of running the very expensiveitem::contained_where()in the common case of only one pocket.Use this helper wherever possible, most notably in
inventory_entry::is_hidden()Describe alternatives you've considered
N/A
Testing
Using Eagle Mountain-trimmed.tar.gz that recreates the scenario from #64139 (comment)
Verify that the inventory UI still looks and functions exactly the same (collapsing etc)
Before:
perf
After:
perf
Additional context
N/A