Fix far-sighted butlers spawning without reading glasses #64168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix far-sighted butlers spawning without reading glasses"
Purpose of change
If there are wear conflicts on profession starting items without
no_auto_equip
, the second item would be silently dropped from inventory. This is noticeable with a far-sighted butler, the butler's default monocle would conflict with the reading glasses and cause the reading glasses to be deleted. The monocle only corrects near-sighted, so the character can't read until they find glasses. The same will occur with near-sighted Butlers, but the since the monocle corrects Near-Sighted its not an issue.Describe the solution
Change the
add_profession_items
to fall-back to putting items in inventory if we can't auto-wear them instead of silently deleting the items.Describe alternatives you've considered
This change does mean that "Near-Sighted" Butler's will spawn with both a monocle and redundant glasses now. We could simply remove the monocle from the Butler instead.
Or, better we could remove the monocle from the default profession items list and modify
profession_item_substitutions
to allow thematic profession substitutions so that "Near-Sighted" butlers spawn with a monocle instead of regular glasses.