Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pockets/collar/hood items to body status for relevant parts #64165

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

sparr
Copy link
Member

@sparr sparr commented Mar 11, 2023

Summary

Interface "Add pockets/collar/hood items to body status for relevant parts"

Purpose of change

When viewing the Body Status interface, mouth parts might be Comfortable or Warm in cold environments, while showing no gear covering them, due to some other gear having a collar. This is relatively opaque to the player. Ditto for pockets/hands and hood/head.

Describe the solution

This PR adds "nameofitem (collar)" to the "Worn" section when viewing a mouth part that is warmed by the collar without being covered by the item with the collar. Ditto "(pockets)" and "(hood)" for hand and head parts.

Describe alternatives you've considered

I couldn't think of another good way to communicate to the player why the body part in question was warmer than expected.

Testing

I've equipped various items with different body part coverage and observed the new entry appearing and disappearing as expected to match the effectiveness of the collar.

Additional context

Originally just COLLAR, added POCKETS and HOOD by request.

I also updated two bits of docs to more accurately describe the function of the COLLAR flag

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Info / User Interface Game - player communication, menus, etc. labels Mar 11, 2023
src/character_attire.cpp Outdated Show resolved Hide resolved
@sparr sparr force-pushed the body_status_worn_collar branch 2 times, most recently from a7b1cd9 to fc5a085 Compare March 11, 2023 22:31
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 12, 2023
@sparr sparr force-pushed the body_status_worn_collar branch from fc5a085 to 6d9eb1b Compare March 12, 2023 03:40
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 12, 2023
@anothersimulacrum
Copy link
Member

Would you mind doing this for POCKETS and HOOD too?

@sparr sparr force-pushed the body_status_worn_collar branch from 6d9eb1b to 7504348 Compare March 13, 2023 02:47
@sparr sparr changed the title Add collar items to body status for mouth parts Add pockets/collar/hood items to body status for relevant parts Mar 13, 2023
@dseguin dseguin merged commit c50f83d into CleverRaven:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants