Intercom UHMWPE armor consistency

[SurFlurer]

Summary

Bugfixes "Intercom should sell the same set of UHMWPE armor."

Purpose of change

Cataclysm-DDA/data/json/npcs/robofac/robofac_intercom/robofac_intercom_prototypes.json

Lines 42 to 47 in 59c0d6e

	"effect": [
	{ "u_sell_item": "RobofacCoin", "count": 6 },
	{ "u_spawn_item": "robofac_military_skirt" },
	{ "u_spawn_item": "robofac_military_vambraces" },
	{ "u_spawn_item": "robofac_military_greaves" },
	{ "u_spawn_item": "robofac_military_helmet" },

Cataclysm-DDA/data/json/npcs/robofac/robofac_intercom/robofac_intercom_prototypes.json

Lines 303 to 309 in 59c0d6e

	"effect": [
	{ "u_sell_item": "RobofacCoin", "count": 6 },
	{ "u_spawn_item": "robofac_military_skirt" },
	{ "u_spawn_item": "robofac_military_vambraces" },
	{ "u_spawn_item": "robofac_military_greaves" },
	{ "u_spawn_item": "robofac_military_mantle" },
	{ "u_spawn_item": "robofac_military_helmet" }

It's self-explanatory.

When Hub01 makes the breakthrough in researching UHMWPE, you can immediately buy the set of robofac_military_*** , or if you choose not to buy them on the spot, you can come back later and buy them. However, if you come back later and buy, you'll not have the robofac_military_mantle, as the code suggests. I tend to see it as a little mistake that the original contributor forgot to add robofac_military_mantle to the list, rather than a punitive measures for pc not buying them on the spot.

Describe the solution

The two sets of UHMWPE armor should be the same.

Describe alternatives you've considered

None.

Testing

All tests good.

Additional context

[bombasticSlacks]

https://github.com/CleverRaven/Cataclysm-DDA/pull/53871/files#diff-9d41b73fc315eccaa85ae5886f90d1102bcd4a05cf98fa38898a0df90db593a7R746 the original PR provided the mantle for free. At some point, this was changed and no one bothered to add the mantle to the rebuy option.

[SurFlurer]

https://github.com/CleverRaven/Cataclysm-DDA/pull/53871/files#diff-9d41b73fc315eccaa85ae5886f90d1102bcd4a05cf98fa38898a0df90db593a7R746 the original PR provided the mantle for free. At some point, this was changed and no one bothered to add the mantle to the rebuy option.

Thank you for merging and pointing that out!