Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock laser cannons #64123

Merged
merged 4 commits into from
Mar 11, 2023
Merged

Conversation

John-Candlebury
Copy link
Member

Summary

Mods "Aftershock: Two new heavy laser cannons"

Purpose of change

All aftershock weapon categories should have heavy weapons, this adds the ones laser based ones.

Describe the solution

Short description of the new weapons:

Izhevsk PLC-75 very big and supposedly antiquated laser cannon, inspired by the historic soviet laser pistol. Unique among other laser guns it uses expendable flashtubes as amunition instead of the usual power cartridge. Combined with its very high per shot power, this pretty much makes it function like a very precise rocket launcher.

Shikishma A-82 tactical laser a much more reasonable heavy laser weapon, and the one that I expect will find common use. On paper the stats are very close to those of the A7 rifle, but every fifth shot will cause an explosion in the target, which increases its turn damage considerably and allows it to damage foes that are usually immune to laser fire.

Both spawn in the general aftershock armories. With the Shikishma being considerably more common.

Testing

Spawned both guns and tried them out for a bit

Additional context

Also noticed lots of ammo effects remain harcoded when they probably shouldn't, plenty of future opportunities there.

@John-Candlebury John-Candlebury changed the title Afs laser cannon Aftershock laser cannons Mar 10, 2023
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 10, 2023
@github-actions github-actions bot added Mods Issues related to mods or modding <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Aftershock Anything to do with the Aftershock mod Spawn Creatures, items, vehicles, locations appearing on map BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 11, 2023
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also adding the json_info!

@@ -14,6 +20,12 @@
"type": "ammo_effect",
"aoe": { "field_type": "fd_elect_anomaly", "intensity_min": 2, "intensity_max": 3, "radius": 0 }
},
{
"id": "TACTICAL_LASER_EXPLOSION",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the ammo effects are quite neat!

@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Straight from the bureaus of the old Soviet Union the PLC-75 is the crude and brutal answer to the constraints posed by the design of heavy laser ordnance. Its use of antiquated flashtube pumped laser technology makes it unwieldy and wholly incompatible with modern equipment, whether this offers any consolation to downrange targets remains a matter of contentious dispute.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@dseguin dseguin merged commit 8496b26 into CleverRaven:master Mar 11, 2023
@John-Candlebury John-Candlebury deleted the afs-laser-cannon branch March 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants