Add Chemistry Proficiencies #64107

Alm999 · 2023-03-10T16:17:52Z

Summary

Balance "Add chemical related proficiencies to crafting recipes"

Purpose of change

Currently, despite being "learnable", all chemical proficiencies have no actual opportunities to be learned. They are not used in any recipes.

This also effectively blocks "Biochemistry" weakpoint from being obtainable, as it requires "Organic Chemistry" knowledge (which can not be learned via in-game activities).

P.S. OK, I've learned my lesson. No more nested branches for each change.

Describe the solution

Simply adding the proficiencies to recipes presents opportunities needed to learn them. My discretion at adding the proficiencies was as follows:

if a recipe requires any manipulation on chemical stuff -> "Principles of Chemistry";
if a recipe mandates operations on inorganic substances (saltpeter, lye, even salt water counts) -> "Inorganic Chemistry";
if a recipe needs organic substances (benzene, citric acid, even ethanol counts) -> "Organic Chemistry" (substances need not to be complex, just being a product of hydrocarbons counts);
if any distillation process is required (both normal and "fine" variants) -> "Distillation" (maybe adjusting for difficulty of fine distillation is needed as a time modifier);
if a product of a recipe is not an "end product" (like "superglue") but intended to be used as an ingredient for more complex chemical synthesis () -> "Principles of Chemical Synthesis";
for any high level mutagens -> "Complex Chemical Synthesis";
if a product is a drug meant for consumption -> "Pharmaceutical Production";
if a recipe requires any manipulation on a (recently) living creature including chemical extraction from its internal organs -> "Biochemistry".

Describe alternatives you've considered

Maybe it is a good idea to also add training recipes provided by chemistry textbooks.

Testing

Tested some (not all, bobviously) recipes in-game. Proficiencies successfully added.

Additional context

None.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JSON & C++ formatters

data/json/recipes/chem/chemicals.json

data/json/recipes/chem/mutagens.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

data/json/recipes/chem/chemicals.json

data/json/recipes/chem/mutagens.json

data/json/recipes/chem/other.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

data/json/recipes/chem/chemicals.json

data/json/recipes/chem/mutagens.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Chemistry proficiences continued #1

citric acid: does not require organic knowledge for production formic acid: does not require organic knowledge for production

napalm: does not actually require any chemical reactions with hydrocarbons. Organic chemistry is out of place here. explosive_hm_rocket: add Handloading for gunpowder handling. gas_fungicidal: remove "Organic Chemistry" because it is just a mix gas_insecticidal: remove "Organic Chemistry" because it is just a mix flamethrower_fuel: remove "Organic Chemistry" because it is just a mix

conc_paralytic, conc_venom: remove Organic Chemistry due to no chemical reactions present

acetylene from carbide should require only basic chemical handling knowledge

Alm999 · 2023-03-14T18:39:38Z

OK, that should be most of them.
I think it is ready for initial reviews.

data/json/recipes/other/power_supplies.json

onura46 · 2023-03-17T01:10:37Z

There's some things I'm not knowledgeable enough to make a judgement call on, but everything I do know about here seems pretty good to go. Great audit!

Alm999 · 2023-03-18T04:27:49Z

Now, that the zinc production recipes have been changed by #63375, I replaced chemistry-related proficiencies with the one I've intentionally avoided (as I intended to have a look at it after the chemistry was fixed) -- "Metallurgy".

Conflicts must be resolved, after all.

Alm999 added 8 commits March 10, 2023 00:57

Update chemicals.json

16ea984

Update chemicals.json

1b66d06

Update other.json

37f5034

Merge branch 'CleverRaven:master' into Chemistry-Proficiency-Stuff

9943be3

Update fuel.json

b42ef2e

Update drugs.json

17a363a

Update mutagens.json

3bb3bcb

Update mutagens.json

6094fcd

github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. labels Mar 10, 2023

github-actions bot reviewed Mar 10, 2023

View reviewed changes

Alm999 and others added 11 commits March 10, 2023 21:20

Update data/json/recipes/chem/chemicals.json

879ee0c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

25a3c7d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

51144c4

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

c9964f9

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

bd97b46

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

c0cc56f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

2aa6938

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

31c8eb7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

cbd9d46

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

5d32b3e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

1fcc558

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 10, 2023

View reviewed changes

Alm999 and others added 2 commits March 10, 2023 21:22

Update data/json/recipes/chem/chemicals.json

f40a1ee

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

e254fbe

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions bot reviewed Mar 10, 2023

View reviewed changes

Alm999 and others added 4 commits March 10, 2023 21:23

Update data/json/recipes/chem/chemicals.json

7c7ccc7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

54cc3cf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/mutagens.json

8ea3400

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update data/json/recipes/chem/chemicals.json

9e5b503

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Alm999 added 2 commits March 12, 2023 20:55

Merge branch 'CleverRaven:master' into Chemistry-Proficiency-Stuff

74960a4

Merge pull request #3 from Alm999/Chemistry_Proficiences_Continued_#1

04f1ffe

Chemistry proficiences continued #1

Alm999 marked this pull request as draft March 12, 2023 15:59

github-actions bot added Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Food / Vitamins Comestibles and drinks BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 12, 2023

Alm999 added 12 commits March 13, 2023 22:17

Merge branch 'CleverRaven:master' into Chemistry-Proficiency-Stuff

61940d7

proficiencies corrections

3754613

citric acid: does not require organic knowledge for production formic acid: does not require organic knowledge for production

Chemical Proficiencies fix

19e6841

conc_paralytic, conc_venom: remove Organic Chemistry due to no chemical reactions present

Add Chemistry and Handloading proficiencies

f4a15d2

Add Chemical proficiencies

15bd67f

Add chemistry proficiencies

a0f6e7b

Add chemical proficiencies

c68488c

Add Handloading to dynamite bomb

4dc7d0b

Merge branch 'CleverRaven:master' into Chemistry-Proficiency-Stuff

41024fb

Merge branch 'CleverRaven:master' into Chemistry-Proficiency-Stuff

347e2f7

Add chemical proficiencies

4cc0f87

github-actions bot added the Items: Armor / Clothing Armor and clothing label Mar 14, 2023

Alm999 added 2 commits March 14, 2023 23:35

Add chemistry proficiencies

ed98d9b

Small correction for chem. profs.

cf9e313

acetylene from carbide should require only basic chemical handling knowledge

Alm999 marked this pull request as ready for review March 14, 2023 18:39

Alm999 changed the title ~~Chemistry proficiency stuff~~ Add Chemistry Proficiencies Mar 14, 2023

onura46 reviewed Mar 17, 2023

View reviewed changes

data/json/recipes/other/power_supplies.json Show resolved Hide resolved

Merge branch 'master' into Chemistry-Proficiency-Stuff

637ad16

kevingranade merged commit 37a32ef into CleverRaven:master Mar 25, 2023

Alm999 deleted the Chemistry-Proficiency-Stuff branch May 4, 2023 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Chemistry Proficiencies #64107

Add Chemistry Proficiencies #64107

Alm999 commented Mar 10, 2023 •

edited

Loading

github-actions bot left a comment

Alm999 commented Mar 14, 2023

onura46 commented Mar 17, 2023

Alm999 commented Mar 18, 2023

Add Chemistry Proficiencies #64107

Add Chemistry Proficiencies #64107

Conversation

Alm999 commented Mar 10, 2023 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

github-actions bot left a comment

Choose a reason for hiding this comment

Alm999 commented Mar 14, 2023

onura46 commented Mar 17, 2023

Alm999 commented Mar 18, 2023

Alm999 commented Mar 10, 2023 •

edited

Loading