Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proficiencies: Fail multiplier -> skill penalty #64079

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Proficiencies: Fail multiplier -> skill penalty #64079

merged 2 commits into from
Mar 10, 2023

Conversation

anothersimulacrum
Copy link
Member

Summary

None

Purpose of change

(Large) bookkeeping change after #63886
This is how they work now, so update the display and the data to match.

Describe the solution

122c357 - update docs, code, add a script for conversion. I probably should have snuck this into #63886, but oh well.
e48b08b - mass automated conversion via script, also add a debugmsg when any data uses the wrong form.

Testing

No (real) changes in crafting test values, no debugmsg on load.

@anothersimulacrum
Change proficiency fail mult. to skill penalty
122c357 
This is what it actually does in practice, so make it reflect that in
naming.
Also added: a script to update all the data. Don't do that by hand.
@anothersimulacrum
Update proficiency JSON for fail mult -> skill pen
e48b08b 
Run the script in tools/json_tools/update_proficiencies.py on data/
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs [Python] Code made in Python Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things Items: Food / Vitamins Comestibles and drinks Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Generic Guns Anything to do with Generic Guns Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 9, 2023
@dseguin dseguin merged commit e641724 into CleverRaven:master Mar 10, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 10, 2023
@anothersimulacrum anothersimulacrum deleted the slight-tweak branch March 10, 2023 05:34
@anothersimulacrum anothersimulacrum mentioned this pull request Mar 10, 2023
Merged
@nemesis688 nemesis688 mentioned this pull request Mar 10, 2023
Closed
@ephemeralstoryteller ephemeralstoryteller mentioned this pull request Mar 22, 2023
Closed
@waveyl waveyl mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

@LyleSY LyleSY Awaiting requested review from LyleSY

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Mom-Bun Mom-Bun Awaiting requested review from Mom-Bun

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Generic Guns Anything to do with Generic Guns Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod [Python] Code made in Python Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anothersimulacrum @dseguin