Fix monsters bleeding on all hits #64068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix monster bleeding on all damage types"
Purpose of change
Fixes #64060
Describe the solution
deal_damage_handle_type
is called for every damage type, even when the amount done is 0, and I made a slight error in calling the bleeding application withrng(1, damage)
. The helpful rng function flips the variables to make sense, so it ended up asrng( 0, 1)
for 0-damage hits. Fixed that.Describe alternatives you've considered
None
Testing
Reproduced the bug, after the changes hit a debug monster with all types of weapons and beheld no bleeding on bash damage.
Additional context