Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monsters bleeding on all hits #64068

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Mar 8, 2023

Summary

Bugfixes "Fix monster bleeding on all damage types"

Purpose of change

Fixes #64060

Describe the solution

deal_damage_handle_type is called for every damage type, even when the amount done is 0, and I made a slight error in calling the bleeding application with rng(1, damage). The helpful rng function flips the variables to make sense, so it ended up as rng( 0, 1) for 0-damage hits. Fixed that.

Describe alternatives you've considered

None

Testing

Reproduced the bug, after the changes hit a debug monster with all types of weapons and beheld no bleeding on bash damage.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 8, 2023
@dseguin dseguin merged commit 22b58a9 into CleverRaven:master Mar 9, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 9, 2023
@Venera3 Venera3 deleted the monster_bleed branch March 9, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blunt Damage Causes Bleeding
2 participants