Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hack's phantom melee #64027

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

Zephanos
Copy link
Contributor

@Zephanos Zephanos commented Mar 7, 2023

Summary

Balance "Removes phantom melee attack that can disrupt aim from explosive/taser hacks."

Purpose of change

Hacks, despite having no damage on their melee and probably not even intended to have melee, will still attempt hit their target. This attack while mostly inconsequential can disrupt survivor aim while issuing no prompt beyond sudden aim reduction.

Describe the solution

Adds "PACIFIST" as a default flag to base_drone that all hacks refer to and have actual melee hacks delete it from their flag list.

Describe alternatives you've considered

Adding a prompt or warning that the hack is disrupting your aim, though that seems like it would be better handled by dodge/speed vs aiming mechanics.
Doing the opposite and adding PACIFIST to every explosive hack instead but considering the drones that actually use melee are the outliers it seemed better to make it the default.

Testing

Tested all explosive/taser hacks and was able to maintain full aim until they detonated.
Tested Manhack and Bloodhound Drone from aftershock to make sure they could still melee, both attacked and killed the debug survivor.

Additional context

Hack melee

hack.melee.mp4

Hack pacified

hack.paci.mp4

Removes explosive hacks phantom melee attacks by giving the base_drone the PACIFIST flag while making drones with melee attacks remove the flag. Includes the bloodhound drone from aftershock.
@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 7, 2023
@kevingranade kevingranade merged commit 9f7a0c8 into CleverRaven:master Mar 7, 2023
@Zephanos Zephanos deleted the Hack-Phantom-Melee-Fix branch March 7, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants