mapgen/remove_veh: remove from main map unconditionally #64002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
removal can otherwise fail if the target is a rotated OMT right at the edge of the reality bubble
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
remove_vehiclesmapgen function can fail to clean up a target vehicle from the main map cache if the target OMT is rotated and right at the edge of the reality bubbleDescribe the solution
Always remove the target vehicle from the main map cache since it's safe and fast.
Describe alternatives you've considered
Checking for OMT coordinate instead or accounting for rotation: no need; removal from cache is safe and fast.
Increasing the size of the reality bubble to an even number of submaps (so that it maps perfectly to OMTs) would also fix this.
Testing
Load save from #63995 and wait one turn. There should be no crash and the FM truck should have disappeared from the Public Washroom to the north.
Additional context
This should be backported to 0.G