Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] I stole the inventor's sparks for dreamer class #63954

Merged
merged 6 commits into from
Mar 11, 2023

Conversation

GuardianDll
Copy link
Member

Summary

Mods "[Xedra Evolved] I stole the inventor's sparks for dreamer class"

Describe the solution

Inventor got his own vitamin, that would work as his own mana in future (i hope) - Metaphysical Connection
800 of this vitamin (10 days) allow him to cast and obtain an item, with random magical properties (only active one) - they have few charges, but give pretty good advantage while using
Fixed the dreamer spells has lack of skill
Edited the inventor's spark spell to use much simpler EoC
For light monster, added him an ability to damage player also - it was intended to have one, but i was not smart enough to make one from the beginning. Now main strategy is cast and run

Additional context

I plan to replace spark mechanic with something smarter, that require the player to sit with laptop for sleepless hours to make some interesting items, but not now

@GuardianDll GuardianDll requested a review from Maleclypse as a code owner March 5, 2023 01:16
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON EOC: Effects On Condition Anything concerning Effects On Condition Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels Mar 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Silently, a part of a world nearby just dissapear.
  • Tiny electric jots jump in your cornea.
  • Your flesh start to rot and regenerate like in timelapse.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 5, 2023
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good stuff! Thank you!

data/mods/Xedra_Evolved/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/effects/effects.json Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Show resolved Hide resolved
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 5, 2023
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 5, 2023
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this turned out really well. Looked back over it and found a couple sentence structure changes but I don't see any changes needed in the mechanical parts. Thanks!

data/mods/Xedra_Evolved/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/itemgroups/dreamer_artifacts.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Outdated Show resolved Hide resolved
data/mods/Xedra_Evolved/spells/XAEA.json Outdated Show resolved Hide resolved
Copy link
Member

@Maleclypse Maleclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work you do!

@dseguin dseguin merged commit c244d36 into CleverRaven:master Mar 11, 2023
@GuardianDll GuardianDll deleted the XAEA branch March 11, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants