Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release version numbers #63862

Merged
merged 3 commits into from
Mar 2, 2023
Merged

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Mar 2, 2023

Summary

None

Purpose of change

The existing tag based versioning system broke at some point, so the version of the 0.G executables is just the commit hash. This PR does some quiche and dirty changes to produce the correct version number.

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 2, 2023
@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Mar 2, 2023
@github-actions github-actions bot added the Code: Tooling Tooling that is not part of the main game but is part of the repo. label Mar 2, 2023
@kevingranade kevingranade changed the title change version number in Windows exe fix release version numbers Mar 2, 2023
@kevingranade kevingranade marked this pull request as ready for review March 2, 2023 03:26
@kevingranade kevingranade merged commit c6acba5 into 0.G-branch Mar 2, 2023
@rumly111
Copy link
Contributor

rumly111 commented Mar 6, 2023

I downloaded 0.G release, and the game extracted to cataclysmdda-0.F directory . Is it fixed now?

@kevingranade kevingranade deleted the kevingranade-release-whoopsie branch May 3, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants