Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adhesive bandages recipe craft multiples. #63824

Merged

Conversation

TaiGambol
Copy link
Contributor

Summary

None

Purpose of change

Crafting adhesive bandages from medical gauze causes >95% of the gauze to be wasted. This changes things so that only ~33% is wasted. By contrast, crafting bandages from medical gauze wastes ~22% of the material, so for multiple smaller cuts, ~33% seems reasonable wastage.

Describe the solution

Edited the adhesive bandage crafting recipe to craft 30 bandages instead of 1.

Describe alternatives you've considered

Changing the recipe to use something other than medical gauze (perhaps a cotton patch? That would make these a field-craftable dressing, now that makeshift bandages are more difficult to craft on the spot)

Testing

Created new character with Health Care 2.
Checked crafting screen, found Adhesive Bandage recipe.
Recipe indicates 30 will be created.
Grabbed first aid kit from evac shelter basement.
Crafted adhesive bandages.
30 were crafted.

Additional context

@Kamayana
Copy link
Contributor

I rather like the idea of being able to make an adhesive bandage with a cotton patch, but that would be in addition to this PR rather than instead of, this making a bunch of them with gauze and tape also makes sense.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 27, 2023
@TaiGambol
Copy link
Contributor Author

Not sure what failed, exactly? It looked like something to do with the mutation code, but I didn't touch that...

@bombasticSlacks
Copy link
Contributor

You probably need more duct tape/medical tape to make 30 bandages, though otherwise the rationale makes sense.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 2, 2023
@bombasticSlacks
Copy link
Contributor

Will need to be restarted after #63856

@TaiGambol
Copy link
Contributor Author

How do I restart?

@bombasticSlacks
Copy link
Contributor

I'll get it

@bombasticSlacks bombasticSlacks force-pushed the TaiGambol-adhesive-bandage-patch branch from 4782eb1 to f2e8af7 Compare March 2, 2023 13:56
@cake-pie
Copy link
Contributor

cake-pie commented Mar 2, 2023

Heads up: #63434 changes adhesive bandages from comestible to generic; it will no longer have charges. In case that PR is merged first, change charges to result_mult.

@bombasticSlacks
Copy link
Contributor

Heads up: #63434 changes adhesive bandages from comestible to generic; it will no longer have charges. In case that PR is merged first, change charges to result_mult.

It almost certainly won't be (though it is on my list to review and test).

Copy link
Contributor

@bombasticSlacks bombasticSlacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to increase time and merge it so that this can get in

data/json/recipes/other/medical.json Outdated Show resolved Hide resolved
data/json/recipes/other/medical.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 3, 2023
@bombasticSlacks bombasticSlacks merged commit 4ea6fb5 into CleverRaven:master Mar 3, 2023
@TaiGambol TaiGambol deleted the TaiGambol-adhesive-bandage-patch branch April 15, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants