Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flying insects not benefiting from their intended effect resistance #63769

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Feb 24, 2023

Summary

None

Purpose of change

Extends the downed immunity to flying insect bodytype as intended (instead of insect_flying).

Describe the solution

Changed the bodytype string that doesn't exist for the one that does.

Describe alternatives you've considered

Finally get around to per-mtype effect resistances, or make bodytypes their own struct holding that info. One of these days, but not in the freezes.

Testing

Spawned a giant wasp queen pre-fix, could sweep to down 100% of the time. After the fix it only happened less than half the time.

Additional context

It was only relevant to non-flying flying insects, so the giant wasp queen is the only one affected in vanilla.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 24, 2023
src/monster.cpp Outdated Show resolved Hide resolved
Co-authored-by: RenechCDDA <[email protected]>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 24, 2023
@kevingranade kevingranade merged commit 4c90f5b into CleverRaven:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants