Keep updating sidebar with AIM active #63575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add invalidate_main_ui_adaptor to AIM display
github-actions
bot
added
[C++]
|
Huge. Transferring vehicle cargo can take literally hours and not updating the minimap during that whole time can be disasterous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add invalidate_main_ui_adaptor to AIM display
Summary
Interface "Keep updating sidebar with AIM active"
Purpose of change
Fixes #63368
Describe the solution
Implement's andrei8l's suggestion.
Describe alternatives you've considered
Testing
I did all of the steps I reported in that issue and saw that the sidebar was updating through all of it. Didn't notice any issues, in any sidebar layout. This change does increase ui_manager::redraw_invalidated()'s processing time from ~6ms to ~19ms, but updating the sidebar was bound to add some processing cost anyway, and it feels like an acceptably imperceptible increase to me. If I'm mistaken in that assumption let me know.
Additional context