Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a drug lab #63403

Merged
merged 10 commits into from
Mar 18, 2023
Merged

Add a drug lab #63403

merged 10 commits into from
Mar 18, 2023

Conversation

MNG-cataclysm
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm commented Feb 2, 2023

Summary

Content "Add a drug lab"

Purpose of change

Add a drug lab, as we do not have a stationary drug lab that can spawn outside of cities.

Describe the solution

Add a drug lab, based off of the moonshine stills' layout, Zombies can spawn there, and it contains meth, chemicals, and lab equipment.

Describe alternatives you've considered

Making multiple drug labs dedicated to one kind of drug, such as one for weed, meth, opioids, etc.

Testing

Spawned the drug lab, went to it, killed the inhabitants, and died to a meth overdose.

Additional context

Jessee, if you're reading this, we need to cook.

Screenshots:
image
drug lab 1

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 2, 2023
data/json/mapgen/drug_lab.json Outdated Show resolved Hide resolved
data/json/mapgen/drug_lab.json Outdated Show resolved Hide resolved
data/json/mapgen/drug_lab.json Outdated Show resolved Hide resolved
data/json/mapgen/drug_lab.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 2, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 2, 2023
@Night-Pryanik
Copy link
Contributor

Some screenshots?

@MNG-cataclysm
Copy link
Contributor Author

Some screenshots?

I have screenshots now, in the main PR box.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 6, 2023
@MNG-cataclysm MNG-cataclysm reopened this Feb 6, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 6, 2023
@JonathanLochridge
Copy link
Contributor

Interesting. It seems it tends to spawn with random chemicals?

From what I can tell the "methlab" itemgroup also throws in some topical items.
I couldn't manage to find where that item group is actually defined though.

I noticed you mentioned making drug-specifc drug labs as an alternative. I overall agree that seperate maps for drug types probably isn't necessary.
Although, I do think having some variance built into a single map is a good idea though.
The simplest way I can think of would be to have the same map. But, have multiple loot tables flavored to a particular drug type. Then have it pick which one to use at certain rates.

Although, even adding just one in is interesting.

Maybe adding a "drug stash" item group to the loot tables might be a good idea?

Copy link
Contributor

@LovamKicsiGazsii LovamKicsiGazsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game loads without errors, not seeing any mapgen errors either.

Just about the only "large scale" suggestion I have is that this misses a roof.
I'd also recommend replacing place_monsters with place_monster in case the dice roll the wrong way. Also, having hazmat zombies spawning here instead of ordinary ones would stop children or dogs from spawning here.

@anothersimulacrum
Copy link
Member

Add a drug lab, as we didn't/do not have a stationary drug lab.

We do, but it's just very rare #28958

@kevingranade kevingranade merged commit a820231 into CleverRaven:master Mar 18, 2023
@MNG-cataclysm MNG-cataclysm deleted the drug_lab branch March 24, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants