Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UNBREAKABLE documentation to JSON_FLAGS.md #63325

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

MrDraMaster
Copy link
Contributor

Summary

None

Purpose of change

UNBREAKABLE wasn't documented but exists, so it should be documented.

Describe the solution

Make sure UNBREAKABLE does what it implies.

Describe alternatives you've considered

Testing

Additional context

flag_UNBREAKABLE gets used in three C++ functions:

  1. item.cpp's item::mod_damage, where it just returns FALSE (so no direct item damage)
  2. item.cpp's item::damage_armor_durability, where it just returns FALSE (so no damage from armor wear)
  3. melee.cpp's Character::handle_melee_wear, where it just returns FALSE (so no damage from smacking something on the head with it)

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 28, 2023
@dseguin dseguin merged commit 7109e85 into CleverRaven:master Jan 29, 2023
@MrDraMaster MrDraMaster deleted the document-unbreakable branch February 12, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants