Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include spell name in default msg for relic spells #63321

Merged

Conversation

inogenous
Copy link
Contributor

Summary

Bugfixes "Include spell name in default msg for relic spells"

Purpose of change

  • Include spell name in You cast: %s! also for relic spell effects
  • Prevents unformatted %s shown in message log when activating relic with, for example, AEA_FATIGUE.

20230128-1

Describe the solution

Spell message for relic effects should be formatted same way as done in activity_handlers::spellcasting_finish

Describe alternatives you've considered

  • For this particular message (shown in screenshot above), another option would be to provide json message for AEA_FATIGUE in data/json/artifact/legacy_artifact_active.json.

Testing

$ ./tests/cata_test
...
All tests passed (28256659 assertions in 977 test cases)

20230128-2

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 28, 2023
* Include spell name in `You cast: %s!` also for relic spell effects
* Prevents unformatted `%s` shown in message log when activating relic with, for example, `AEA_FATIGUE`.
@inogenous inogenous force-pushed the bugfix-relic-spell-default-message branch from b4694ae to 5c840de Compare January 29, 2023 10:06
@dseguin dseguin merged commit af52209 into CleverRaven:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants