fix xl/xs armor recipe inconsistencies #63261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixed some xl/xs armor recipes to make tool requirements consistent across all sizes"
Purpose of change
I've noticed a number of xs/xl armor crafts that were missing tool requirements that are in the recipes for normal sized armor. Except for three, every recipe change just makes the tool requirements for crafting armor consistent across all sizes. The exceptions are changing the component for xs fingerless survivor gloves to xs survivor gloves (was normal sized survivor gloves previously), the same fix for xs fingerless light survivor gloves, and removing the recipes for all sizes of the obsolete ornamental plate armor.
Describe the solution
Changed component of xs fingerless survivor gloves recipe to xs survivor gloves (used survivor gloves previously)
Changed component of xs fingerless light survivor gloves recipe to xs light survivor gloves (used light survivor gloves previously)
Removed recipes for ornamental plate armor, xl ornamental plate armor, and xs ornamental plate armor
List of all tool requirements added to armor recipes:
xs lorica segmentata - anvil 3 hammer 3 chisel 3
xl/xs low steel lamellar cuirass - awl 1
xl/xs hardened steel lamellar cuirass - awl 1
xs cuirass - chisel 3
xl/xs scrap cuirass - cutting 2 hammer 1
xs tire cuirass - cutting 2 hammer 1 curved needle 1
xl pair of steel arm guards - chiseling 3 swage & die set
xs pair of steel arm guards - chiseling 3
xl/xs pair of scrap arm guards - hammer 1 metal sawing 1
xs pair of tire arm guards - cutting 2 awl 1 curved needle 1
xs pair of armored gauntlets - chiseling 3
xs pair of steel leg guards - chisel 3
xl/xs pair of scrap leg guards - hammer 1
xs pair of tire leg guards - awl 1 curved needle 1
xs pair of armored boots - chisel 3
xs pair of biosilicified chitin boots - fine cutting 1
xl/xs pair of scrap boots - hammer 1
xs kabuto - chisel 3
xs galea - chisel 3
xs great helm - chisel 3
xs biosilicified chitin helmet - fine cutting 1 sewing 1
xl/xs survivor fire mask - arc welder/integrated multi/makeshift arc welder/soldering iron/welding kit (charges correspond with size)
xs conical helm - chisel 3
xs nasal helm - chisel 3
xs/xl scrap helmet - cutting 2 hammer 1
xs plate armor - chisel 3
xs biosilicified chitin armor - fine cutting 1 sewing 1 awl 1
xs/xl leather body armor - awl 1
If you question the balance of any of these requirements, remember that this is just making the tool requirements the same as the regular sized armor recipes. Balance concerns for these recipes should probably be a separate issue/pr
Describe alternatives you've considered
Tools/qualities could be added to inheretance/copy-from (for all I know, maybe it's supposed to and just doesn't work) but that is considerably above my experience as a first contributor
Testing
Simply look at the recipes of the changed items, and make sure the tool requirements match across xl/normal/xs
Additional context