fixes encumbrance_covered muts being covered by integrated armor #63182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Integrated armors no longer cause encumbrance from some mutations"
Purpose of change
Currently, integrated armors still count as standard clothing for the purposes of mutations which become encumbering when covered tightly, such as photophore or webbed hands. Fixes #63161 . This PR is an alternative to #63171 , which solves this same problem in an alternative way. I personally think changing the check itself is a safer bet than adding a new flag to mutations, but the ultimate decision is up to the devs.
Steps to reproduce the bug are in the linked report.
Describe the solution
The check to ensure that only oversized clothing was worn on relevant bodyparts was replaced with the new "wearing_fitting_on" method from #59092 , which not only ignores oversized clothes, but also integrated armors.
Describe alternatives you've considered
I considered not doing this (and, facing compiler errors, giving up) and just letting the other PR's solution handle it.
Testing
Additional context
I would not consider myself a programmer, certainly not for anything as annoying to work with as cpp. I'm also not a very good cdda player. I would highly recommend that this PR is tested by people very familiar with both the game and the language to ensure I didn't horribly break anything, since I only got this far by trial and error.