-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup office tower, room dividers #63054
Merged
ZhilkinSerg
merged 4 commits into
CleverRaven:master
from
LovamKicsiGazsii:office-tower-overhaul
Mar 2, 2023
Merged
Cleanup office tower, room dividers #63054
ZhilkinSerg
merged 4 commits into
CleverRaven:master
from
LovamKicsiGazsii:office-tower-overhaul
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jan 9, 2023
Should this close #58152? |
Ok, got it. |
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Jan 10, 2023
Maleclypse
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate it. Any cleanup you want to do to the Xedra Office is great. I'm not great at mapgen.
For another PR, sure. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Office tower cleanup, updates office nesteds, adds room dividers"
Purpose of change
I came to cleanup office_tower.json and office_nested.json, and stayed to overhaul the short office tower.
Describe the solution
office nested chunks:
Large office tower:
place_monsters
withmonster
,place_vehicles
withvehicles
Office tower:
place_vehicles
withvehicles
Describe alternatives you've considered
Adding room dividers to a couple more locations.
Testing
Debug-spawned multiple times to check if nested chunks spawn alright.
Additional context
Screenshots:
Nested chunks are highlighted.
Office building:
Office tower: