Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASRG adjustments #62814

Merged

Conversation

anoobindisguise
Copy link
Contributor

@anoobindisguise anoobindisguise commented Dec 22, 2022

Summary

Balance "Adjustments to ASRGs"

Purpose of change

ASRGs were too big and heavy. My original plan for them split them into the bare minimum (1:1 with NASA specs) and a super heavily armored one that made it into the game. However it's just too big and too heavy. My thinking was that it was made super armored by the military to make it resistant to zombies/portals/etc as they were deployed en masse before the cataclysm (plutonium sourced from XEDRA/the nether making them cheap) but the military is swapping over to diesel generators so these are becoming almost entirely a XEDRA thing.

Describe the solution

The ASRG by default is 39x46x76cm, though its actual displacement is not exactly this much due to it not being a perfect square, and it is only 32 kg. I'm assuming they're still being shielded a little so I've redesigned them to have a milcomp bounding box giving them about 150 liters total (down from 200) and 100 kg (68 kg of milcomp plating) and reduced their durability a bit.
I also let them work in cars, because I originally thought they were incompatible with cars due to the appliance weirdness but it turns out perpetual reactors work perfectly in cars! So now you can provide 0.1% of your total necessary electric motive power with an ASRG if you want!

Describe alternatives you've considered

Remove the armor plating entirely, go with ONLY the NASA specs and make them rather fragile to car crashes/zombies/etc. However the Ultica/MSX/UDP/etc sprites depict a pretty large box so I don't wanna force tileset authors to make a new sprite for it.

Testing

I tested and confirmed no errors + everything loads up and worked perfectly, spawned an electric car and saw +130w per ASRG I installed in it.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Appliance/Power Grid Anything to do with appliances and power grid Vehicles Vehicles, parts, mechanics & interactions Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 22, 2022
@anoobindisguise
Copy link
Contributor Author

Looks like basic build failure isn't actually mine.

@irwiss
Copy link
Contributor

irwiss commented Dec 22, 2022

May be remove CARGO flag and size field on the vpart definition while you're there, or is there a reason you can place items in it?

@anoobindisguise
Copy link
Contributor Author

May be remove CARGO flag and size field on the vpart definition while you're there, or is there a reason you can place items in it?

Only the appliance has it, I think the reason was that you could stack stuff on top of it since it's not moving around a lot. Not super necessary though, I'll do away with it.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Dec 22, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 22, 2022
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jan 5, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 5, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 17, 2023
@ZhilkinSerg ZhilkinSerg merged commit 901a68b into CleverRaven:master Mar 5, 2023
@RenechCDDA
Copy link
Member

The added vehicle part ap_compact_ASRG_containment has the same id as the appliance, causing it to overwrite the appliance's values. This is causing some rather strange, erroneous behavior. Just need to bump the vehicle part's ID out to a unique one.

@anoobindisguise anoobindisguise deleted the anoobindisguise-asrg-tweaks branch July 31, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants