Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Toggle Prone keybinding option #62766

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

Kamayana
Copy link
Contributor

@Kamayana Kamayana commented Dec 17, 2022

Summary

Features "Adds a Toggle Prone keybinding option"

Purpose of change

There are toggle options for walk, run and crouch in keybindings that default unbound, but none for going prone. My current character has broken legs and I found I wanted a quick shortcut for going back prone after sitting up to drive a car.

Describe the solution

Duplicated all the toggle_crouch settings and replaced them with crouch.

Describe alternatives you've considered

Using the cycle movement button or menu instead, but I prefer using ctrl+w/r/c for it.

Testing

Opened keybindings and binded toggle prone, used it to toggle prone. Used other stance keys to make sure nothing was broken.

Additional context

I am unsure if the text in these files automatically gets sent to translation or not, but that should get sent eventually. That does mean this PR is locked out for now due to string freeze.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 17, 2022
@Kamayana Kamayana force-pushed the toggle_prone_keybinding branch 2 times, most recently from d59273a to 1ac801f Compare December 22, 2022 02:29
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 22, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 21, 2023
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Mar 8, 2023
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed stale Closed for lack of activity, but still valid. labels Mar 9, 2023
@dseguin dseguin merged commit 5f838a5 into CleverRaven:master Mar 10, 2023
@Kamayana Kamayana deleted the toggle_prone_keybinding branch January 9, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants