Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sassafras Trees and Craftable Root beer #62684

Merged
merged 11 commits into from
Mar 5, 2023

Conversation

cxmuelle
Copy link
Contributor

@cxmuelle cxmuelle commented Dec 11, 2022

Summary

Content "Added Sassafras Trees, sassafras roots, and craftable (fermented) rootbeer to the game!"

Purpose of change

Fixes #57658.

Describe the solution

The sassafras trees are about as rare as a mulberry tree and also look like them. The roots are based on the various bark Items. The rootbeer has an unfermented and a fermented form to follow alongside the standard for brewing and uses a still/vat. It takes 1 day to make it. I based it on this recipe, (https://honest-food.net/root-beer-syrup-recipe/).

Describe alternatives you've considered

Going without the sweet beverage.

Testing

I tested this by spawning the correct items and making it. I plan on adding more tests and screenshots to further showcase testing but I need to start this pull request for a class assignment 😬 !

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 11, 2022
Copy link
Member

@NetSysFire NetSysFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cxmuelle
Copy link
Contributor Author

default_person -> using a basic person
Tree found -> Found the sassafras tree in game
picked -> proper text box and a proper harvest amount
searched_root_no_items -> have items but don't have recipe
can make -> spawned necessary book and increased skill to learn recipe
recipie items not yet made -> found it
missing_proficencys_debuff -> we aren't the best at making it but we can
not_done -> in a vat fermenting
rootBEER-> we have drink :)

sorry for spam but these are test images :)
After this I will push changes to the amount of water used and the multiplier

@bombasticSlacks
Copy link
Contributor

rebased this so it will run again

@ZhilkinSerg ZhilkinSerg merged commit a47f23e into CleverRaven:master Mar 5, 2023
@Formosusssss
Copy link

may as well implement feature of production of MDMA later, as safrol is used in synthesis of one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sassafras Trees and craftable root beer
7 participants