Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin matrix clang++-12 build to ubuntu-22.04 because the fake sysroot … #62549

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Dec 3, 2022

…fix only works on that OS

Summary

None

Purpose of change

During the transitional period, a job ubuntu-latest may run on either Ubuntu 20.04 or Ubuntu 22.04. It's bad. I think we should clearly specify ubuntu-22.04 in workflow yaml.

  • BrettDong

#62405 (comment)

Describe the solution

PR is self explanatory.

Describe alternatives you've considered

Testing

Matrix build on this PR.

Additional context

@github-actions github-actions bot added Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 3, 2022
@dseguin dseguin merged commit 7b9962f into CleverRaven:master Dec 3, 2022
anoobindisguise pushed a commit to anoobindisguise/Cataclysm-DDA that referenced this pull request Dec 3, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 4, 2022
@akrieger akrieger deleted the ubuntu_pinning branch December 4, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants