Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some mis-use of positional arguments #62542

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/3606550687/jobs/6077971220 reported some mix use of non-positional arguments and positional arguments, which is kind of "undefined/unspecified behavior" in C-style format string.

Describe the solution

Fix the problem.

Describe alternatives you've considered

Testing

Additional context

@BrettDong BrettDong requested a review from LyleSY as a code owner December 3, 2022 03:28
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 3, 2022
@dseguin dseguin merged commit 3f64079 into CleverRaven:master Dec 3, 2022
@BrettDong BrettDong deleted the pos-arg branch December 6, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants