Fix Disconsolate Merc crash #62362
Merged
Fix Disconsolate Merc crash #62362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
Do we still get the crash if you give him a debug invisibility trait, prior to running the EOC? |
|
Assuming that'd happen at the same point during turn processing, I don't think that would change anything. Plus it would mean actually figuring out the involved json and/or EOC code and fiddling around with it. |
github-actions
bot
added
the
BasicBuildPassed
|
I would still like it tested but I am okay with merging this to fix the issue. THe underlying code still needs a fix at some point so I think we should call this a partial fix, not complete. |
andrei8l
added a commit
to andrei8l/Cataclysm-DDA
that referenced
this pull request
Nov 25, 2022
This reverts commit 18761d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix Disconsolate Merc crash"
Purpose of change
Partially fixes #60938
Describe the solution
The crash is caused by outdated info on visible monsters when the forced redraw option is enabled and the compass widget tries to access the already removed npc. This adds a call to update the monster info before redrawing.
Describe alternatives you've considered
Figure out which order all the stuff happens in and find a way to shuffle things around without adding another call. That's probably not possible, though.
Or remove the force redraw option because it also causes other isses (#58795). But that obviously has more implications.
Testing
Load the save and walk north. To cause a crash both the "force redraw" option and the compass widget have to be enabled. With this fix there won't be a crash even with them enabled.
Additional context
http://files.catbox.moe/oevx9t.zip
Thanks @RenechCDDA for providing the save.