Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting options now work correctly again #62205

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Waiting options now work correctly again #62205

merged 1 commit into from
Nov 14, 2022

Conversation

Ilysen
Copy link
Contributor

@Ilysen Ilysen commented Nov 13, 2022

Summary

Bugfixes "Waiting to catch your breath, until the weather changes, etc. now works properly"

Purpose of change

#61459 broke a few of the waiting options; waiting until midnight, waiting to catch your breath, and waiting for the weather to change all stopped functioning correctly, as they were not assigned to the updated list indices that they were supposed to be. This PR makes the indices each work correctly.

Describe the solution

All malformed list indices for different options are now assigned correctly.

Describe alternatives you've considered

N/A

Testing

I went through each option on the waiting list to make sure everything worked as intended, which it seemed to, at least. I did it with and without an alarm.

Additional context

Test your code, people!

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 13, 2022
@dseguin dseguin merged commit f1b7a72 into CleverRaven:master Nov 14, 2022
@Ilysen Ilysen deleted the waiting-fix branch November 14, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants