Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bodypart_color_text.json clause priority #62191

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

Inglonias
Copy link
Contributor

Summary

Bugfixes "Fixes bodypart status text color for very injured characters"

Purpose of change

I noticed while my latest TCL challenge run was being eaten alive that the color of the text on the sidebar was wrong and behaving badly. This was caused by the fact that lower intensity clauses came before higher intensity ones, and therefore took priority.

Describe the solution

Re-order the clauses in the file with the most injured state being first and the least injured state being last.

Describe alternatives you've considered

Ignoring it.

Testing

This is with the current JSON file...
image

And this is with the fixed one:
image

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. Limbs Limbs, mutable limbs, and code related to them. astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 12, 2022
@dseguin dseguin merged commit 08775ad into CleverRaven:master Nov 14, 2022
@Inglonias Inglonias deleted the fix_very_owie_sidebar branch November 17, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants