Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing output from cataclysm-tiles.exe --help #62178

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

alef
Copy link
Contributor

@alef alef commented Nov 11, 2022

Summary

Bugfixes "missing output from cataclysm-tiles.exe --help"

Purpose of change

The TILES (SDL) version in Windows is a GUI subsystem, so there is no I/O on a terminal.
.\cataclysm-tiles.exe --help does not show anything.

Describe the solution

cataclysm-tiles.exe now uses AttachConsole() to its parent terminal.

Describe alternatives you've considered

Testing

Run locally, main menu shown, keyboard input works, double-clicking on cataclysm-tiles.exe works.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Nov 11, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 11, 2022
@alef alef marked this pull request as ready for review November 11, 2022 18:49
@NetSysFire NetSysFire added the OS: Windows Issues related to Windows operating system label Nov 12, 2022
@dseguin dseguin merged commit 9795797 into CleverRaven:master Nov 14, 2022
@alef alef deleted the win-print-help branch November 14, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions OS: Windows Issues related to Windows operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants