Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertising brochures in mailboxes #62149

Merged
merged 7 commits into from
Nov 12, 2022
Merged

Conversation

Hansendiet
Copy link
Contributor

Summary

Content "Added six different advertising brochures which reveal the map and now spawn in mailboxes"

Purpose of change

Fixes #62066
It was always kinda weird to me that people living in an area would receive tourist maps or trail guides, so I added six different advertising brochures which reveal different groups of buildings on the map. In my opinion this is a way better fit thematically.
I will probably do a lot more work on the entire postal system in the future since I think it is kind of underutilized, but this seemed like a nice first issue to ease myself into the project.

Describe the solution

As stated above, added six advertising brochures that reveal different groups of buildings on the map and added them to the mail spawngroup. Also removed the touristmap and trailguide from the mail spawngroup.

Describe alternatives you've considered

Leaving it as is, but my passion for mailboxes would not allow for that.

Testing

Spawned into the world and searched a lot of mailboxes. All of the brochures spawn at approximately the correct rate and reveal the correct buildings.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Lore Game lore, in-game communication. Also the Lore tab. Spawn Creatures, items, vehicles, locations appearing on map <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Nov 9, 2022
data/json/items/book/maps.json Outdated Show resolved Hide resolved
data/json/snippets/snippets.json Outdated Show resolved Hide resolved
Changed id, name, description and use message.
Also added arcade and internet cafe to the revealed terrain.
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This is a small brochure advertising for local malls with an address below each entry. Using it will add roads an local malls, strip malls and megastores to your map.
  • You add roads and local malls, strip malls and megastores to your map.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2022
Since adding the word "megastores" to the dictionary somehow broke one of the test, I just removed it.
@Fris0uman Fris0uman merged commit 76eefb9 into CleverRaven:master Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Lore Game lore, in-game communication. Also the Lore tab. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brochures or pamphlets in mailboxes
4 participants