-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertising brochures in mailboxes #62149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Lore
Game lore, in-game communication. Also the Lore tab.
Spawn
Creatures, items, vehicles, locations appearing on map
<Bugfix>
This is a fix for a bug (or closes open issue)
astyled
astyled PR, label is assigned by github actions
labels
Nov 9, 2022
NetSysFire
reviewed
Nov 9, 2022
Changed id, name, description and use message. Also added arcade and internet cafe to the revealed terrain.
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Nov 9, 2022
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Nov 9, 2022
Since adding the word "megastores" to the dictionary somehow broke one of the test, I just removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Lore
Game lore, in-game communication. Also the Lore tab.
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Added six different advertising brochures which reveal the map and now spawn in mailboxes"
Purpose of change
Fixes #62066
It was always kinda weird to me that people living in an area would receive tourist maps or trail guides, so I added six different advertising brochures which reveal different groups of buildings on the map. In my opinion this is a way better fit thematically.
I will probably do a lot more work on the entire postal system in the future since I think it is kind of underutilized, but this seemed like a nice first issue to ease myself into the project.
Describe the solution
As stated above, added six advertising brochures that reveal different groups of buildings on the map and added them to the mail spawngroup. Also removed the touristmap and trailguide from the mail spawngroup.
Describe alternatives you've considered
Leaving it as is, but my passion for mailboxes would not allow for that.
Testing
Spawned into the world and searched a lot of mailboxes. All of the brochures spawn at approximately the correct rate and reveal the correct buildings.
Additional context