Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gun variants, part the third. #62074

Merged
merged 95 commits into from
Apr 16, 2023

Conversation

DoctorBoomstick
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick commented Nov 4, 2022

Summary

None

Purpose of change

Continues work started in #61598 and #61893, carrying on the inexorable march towards extending the variants system across more firearms which currently lack a more generic variation.

Describe the solution

I’ve created variants for all the weapons in .22 calibre, 7.62x25mm, 9x18mm, and 5.7x28mm. I’ve also slightly adjusted the existing variants present across the 5.7mm guns (the FN P90, Kel-Teck P50, and FN PS90), to make the names more compact and the descriptions less wordy. In doing these changes, many of the magazines have also been given appropriate variants were applicable.

Describe alternatives you've considered

No real alternatives to speak of, save for perhaps finding ways to cut down on the number of magazine variants.

Testing

All elements have been bug tested on the latest experimental builds, with the game loading just fine.

Additional context

Consult #61598 and #61893 for the first two parts to this expansion of the existing gun variants.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 4, 2022
Copy link
Contributor

@TheShadowFerret TheShadowFerret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who dares bring British spellings to my American apocalypse

DoctorBoomstick and others added 26 commits March 2, 2023 23:00
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 15, 2023
@bombasticSlacks
Copy link
Contributor

bombasticSlacks commented Apr 16, 2023

This looks good to me, could you add the barrel lengths to the guns? #64961 gives an example.

wrong PR mb

@bombasticSlacks bombasticSlacks merged commit a447fd9 into CleverRaven:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants