-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More gun variants, part the third. #62074
Merged
bombasticSlacks
merged 95 commits into
CleverRaven:master
from
DoctorBoomstick:gun_variants_3
Apr 16, 2023
Merged
More gun variants, part the third. #62074
bombasticSlacks
merged 95 commits into
CleverRaven:master
from
DoctorBoomstick:gun_variants_3
Apr 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariants for the .22 guns.
…iants, adds needed variants for magazines.
MNG-cataclysm
approved these changes
Nov 4, 2022
anothersimulacrum
approved these changes
Nov 4, 2022
TheShadowFerret
suggested changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who dares bring British spellings to my American apocalypse
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
wrong PR mb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Continues work started in #61598 and #61893, carrying on the inexorable march towards extending the variants system across more firearms which currently lack a more generic variation.
Describe the solution
I’ve created variants for all the weapons in .22 calibre, 7.62x25mm, 9x18mm, and 5.7x28mm. I’ve also slightly adjusted the existing variants present across the 5.7mm guns (the FN P90, Kel-Teck P50, and FN PS90), to make the names more compact and the descriptions less wordy. In doing these changes, many of the magazines have also been given appropriate variants were applicable.
Describe alternatives you've considered
No real alternatives to speak of, save for perhaps finding ways to cut down on the number of magazine variants.
Testing
All elements have been bug tested on the latest experimental builds, with the game loading just fine.
Additional context
Consult #61598 and #61893 for the first two parts to this expansion of the existing gun variants.