Fix Nonrigid nested container can't store picked up items

[EIIKaO]

Summary

Bugfixes "Nonrigid nested containers can't store picked up items"

Purpose of change

• Fix Nonrigid nested containers can't store picked up items #62068
  Improved to collect all pockets, even nested non-rigid pockets, and then fill them with items in the order of priority.

Describe the solution

In current codes, nested non-rigid containers did not contain picked up count_by_charges items.
Improved the method to collect all pockets, even nested non-rigid pockets, calculate capacity limits by the parent-child relationship, and then fill the items based on priority.

Describe alternatives you've considered

None

Testing

In-game testing done.

Repro method by the issue #62068

• Spawn a nonrigid container like a plastic zipper bag, as well as a wearable container like a backpack.
• Wear the backpack, put the plastic zipper bag in the backpack.
• Set the priority on the bag to a high value
• (Optionally) set an item whitelist for a specific item that fits in the bag.
• Spawn soap and put it on the ground.
• Pick up the soap.
• [NEW] Confirm that the soap were put into the plastic zipper bag.

Additional context

Thanks to @akrieger, his report, which accurately pointed out this problem, struck a chord with my laziness.

[mqrause]

Can't do a full review right now, but it looks like most if not all you're doing there could be done with item_location already.

[EIIKaO]

@mqrause Thanks for advice.
This is actually code I wrote about two months ago.
Since then I learned a bit more about item_location too. ( I haven't PR'd it yet, but the following content, related to the feature that allows follower to read e-books: EIIKaO@8d3f274 )

I would like to go over the code again myself, but it would be even more helpful if you could indicate more specific points( or direction ) of improvement .

[mqrause]

I'll have to look at it a bit closer this weekend, but as a quick and hopefully helpful pointer:
You can build the top level outfit locations with item_location parent_location( guy, pointer_to_worn_item ) and then go deeper level by level with item_location content_location( parent_location, pointer_to_content_item ). With these you can call item_location::parents_can_contain_recursive and item_location::max_charges_by_parent_recursive to check if/how much of something really fits inside a nested container.

[EIIKaO]

@mqrause Thanks for useful information.

After my earlier post, I have checked myself to see if I could make use of item_location, and have confirmed that it may at least substitute it with a tuple of item_location without using unique_ptr.

Now I will seek to simplify it further with the new information you have given me.

[EIIKaO]

Following mqrause's advice, I adopted a style that utilizes item_location.
Now uses item_location's function to allow check if/how much of something really fits inside a nested container.

Unfortunately, my poor knowledge and skills, have resulted in the generation of code that is not very readable.

[anothersimulacrum]

Would you be able to add a test for this case, so we can prevent bugs like this?
You may also be able to improve on readability by using a struct instead of a tuple.

[EIIKaO]

Would you be able to add a test for this case, so we can prevent bugs like this?

I am interested but it may be difficult for me to make it.
One reason is that I do not have an environment to build the tests.

You may also be able to improve on readability by using a struct instead of a tuple.

I will try this one quickly.
Thank you for your advice.