Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hiking pants #61945

Merged
merged 9 commits into from
Oct 30, 2022
Merged

Added hiking pants #61945

merged 9 commits into from
Oct 30, 2022

Conversation

bean-b
Copy link
Contributor

@bean-b bean-b commented Oct 27, 2022

Summary

Content "Adds hiking pants."

Purpose of change

I felt this was a lacking item in terms of the current pants offered, especially with the other hiking/outdoor gear. Also, I’ve been meaning to contribute to the game for awhile, and this seemed like a good place to start so I can work on larger changes in the future.

Describe the solution

I based the stats off of existing cargo pants, making them have slightly less encumbrance, less pockets, waterproof and made of synthetic fabric. They are a relatively rare spawn in normal clothing groups, and can also be found in hunting supply stores.

Describe alternatives you've considered

Not adding this item.
Also many hiking pants are convertible into shorts, but this feature is also not seen on a large percentage of these types of pants, and so it didn't feel like a necessary feature. Also potentially making it craftable, however as many pants such as work pants and army pants are not, that didn't seem like a necessity.

Testing

Spawned it in game, stats were as expected. Tested repairing it. Checked hunting supply stores, and verified that it spawned after checking a few.

Additional context

Modeled after something like these:
https://www.rei.com/product/143879/kuhl-freeflex-roll-up-pants-womens-32-inseam

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Oct 27, 2022
data/json/itemgroups/Clothing_Gear/clothing.json Outdated Show resolved Hide resolved
data/json/itemgroups/Clothing_Gear/clothing.json Outdated Show resolved Hide resolved
data/json/itemgroups/Clothing_Gear/clothing.json Outdated Show resolved Hide resolved
data/json/itemgroups/Clothing_Gear/clothing.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Oct 29, 2022
@github-actions github-actions bot added Items: Armor / Clothing Armor and clothing Spawn Creatures, items, vehicles, locations appearing on map labels Oct 29, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 30, 2022
@bombasticSlacks bombasticSlacks merged commit fa03493 into CleverRaven:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants