-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hiking pants #61945
Merged
Merged
Added hiking pants #61945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maleclypse
reviewed
Oct 27, 2022
TheShadowFerret
suggested changes
Oct 29, 2022
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
Co-authored-by: TheShadowFerret <[email protected]>
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Oct 29, 2022
github-actions
bot
added
Items: Armor / Clothing
Armor and clothing
Spawn
Creatures, items, vehicles, locations appearing on map
labels
Oct 29, 2022
bombasticSlacks
approved these changes
Oct 30, 2022
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds hiking pants."
Purpose of change
I felt this was a lacking item in terms of the current pants offered, especially with the other hiking/outdoor gear. Also, I’ve been meaning to contribute to the game for awhile, and this seemed like a good place to start so I can work on larger changes in the future.
Describe the solution
I based the stats off of existing cargo pants, making them have slightly less encumbrance, less pockets, waterproof and made of synthetic fabric. They are a relatively rare spawn in normal clothing groups, and can also be found in hunting supply stores.
Describe alternatives you've considered
Not adding this item.
Also many hiking pants are convertible into shorts, but this feature is also not seen on a large percentage of these types of pants, and so it didn't feel like a necessary feature. Also potentially making it craftable, however as many pants such as work pants and army pants are not, that didn't seem like a necessity.
Testing
Spawned it in game, stats were as expected. Tested repairing it. Checked hunting supply stores, and verified that it spawned after checking a few.
Additional context
Modeled after something like these:
https://www.rei.com/product/143879/kuhl-freeflex-roll-up-pants-womens-32-inseam