Allow filtering by ammotype in gun stats tool #61599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove an unnecesary noisy print statement.
github-actions
bot
added
[Python]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Would be nice to be filter by ammo, huh? I made this change months ago and it's been sitting around since, may as well push it back.
Describe the solution
Allow specifying an 'ammo' string, and if an entry would be printed that does not contain this ammo string within their ammo field, skip that entry.
Describe alternatives you've considered
Making this fancier. Too lazy.
Testing
flake8 tools/json_tools/gun_stats.py
tools/json_tools/gun_stats.py -a 762R data/json
#61598 (comment)