Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subparts can track separate lists of sublocations that exist bellow them #61576

Merged
merged 7 commits into from
Oct 17, 2022

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Oct 9, 2022

Summary

None

Purpose of change

No one has made an issue but multiple people have reported a bug where binoculars are always uncomfortable to wear. This is because there is no relation between the secondary hanging locations and primary locations like upper and lower torso.

Supersedes #61545

Describe the solution

Subparts can now specify an array of other subparts that exist bellow them. This is the list of location tested against when checking for comfort / discomfort.

Added a message letting you know when you wear something what is chaffing, where and why.

Describe alternatives you've considered

Testing

make the stethoscope weigh more than it does and try putting it on with a belly wrap
image

binoculars alone
image

binoculars after wearing a sweater
image

binoculars with only a belly wrap
image

Additional context

The location choices are:
Neck -> upper torso
Hanging Front -> upper and lower torso
Hanging Back -> upper and lower torso
Belt -> the hips
Draped legs -> the hips and upper legs

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 9, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 9, 2022
@Night-Pryanik Night-Pryanik changed the title Subparts can track seperate lists of sublocations that exist bellow them Subparts can track separate lists of sublocations that exist bellow them Oct 10, 2022
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • <color_c_red> the %s rubs uncomfortably against your unpadded %s

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 17, 2022
@dseguin dseguin merged commit 0d87154 into CleverRaven:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants