-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subparts can track separate lists of sublocations that exist bellow them #61576
Merged
dseguin
merged 7 commits into
CleverRaven:master
from
bombasticSlacks:fix-secondary-discomfort
Oct 17, 2022
Merged
Subparts can track separate lists of sublocations that exist bellow them #61576
dseguin
merged 7 commits into
CleverRaven:master
from
bombasticSlacks:fix-secondary-discomfort
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseguin
reviewed
Oct 10, 2022
Co-Authored-By: David Seguin <[email protected]>
…icSlacks/Cataclysm-DDA into fix-secondary-discomfort
dseguin
reviewed
Oct 17, 2022
Co-authored-by: David Seguin <[email protected]>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
No one has made an issue but multiple people have reported a bug where binoculars are always uncomfortable to wear. This is because there is no relation between the secondary hanging locations and primary locations like upper and lower torso.
Supersedes #61545
Describe the solution
Subparts can now specify an array of other subparts that exist bellow them. This is the list of location tested against when checking for comfort / discomfort.
Added a message letting you know when you wear something what is chaffing, where and why.
Describe alternatives you've considered
Testing
make the stethoscope weigh more than it does and try putting it on with a belly wrap

binoculars alone

binoculars after wearing a sweater

binoculars with only a belly wrap

Additional context
The location choices are:
Neck -> upper torso
Hanging Front -> upper and lower torso
Hanging Back -> upper and lower torso
Belt -> the hips
Draped legs -> the hips and upper legs