-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flagpoles and hoisting flags #61551
Merged
Merged
Flagpoles and hoisting flags #61551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… houses and shooting range
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[C++]
Changes (can be) made in C++. Previously named `Code`
[JSON]
Changes (can be) made in JSON
[Markdown]
Markdown issues and PRs
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Oct 8, 2022
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: No Hope
Relating to the mod No Hope
labels
Oct 8, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Oct 8, 2022
This was referenced Oct 8, 2022
Fris0uman
reviewed
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Documentation>
Design documents, internal info, guides and help.
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
[Markdown]
Markdown issues and PRs
Mods: No Hope
Relating to the mod No Hope
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Flagpoles and hoisting flags"
Purpose of change
Make it possible to hoist flags on flagpoles.
Describe the solution
layering.json
Other:
Describe alternatives you've considered
Make hoisting a flag an explicit action.
Testing
Implemented on the tileset side for MSX (see screenshot and PR links).
Visited all modified locations.
Additional context
Made post sprites but no layering yet (needs merge of this):
Screenshot of hoisted flags in the MSX tileset: