Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit of fill_water_with_dirt construction group for consistency #61536

Merged

Conversation

ashGlaw
Copy link
Contributor

@ashGlaw ashGlaw commented Oct 8, 2022

Summary

Bugfixes "Audit of fill_water_with_dirt construction group for consistency"

Purpose of change

The amount of soil required to fill a murky water tile was lower than the others in its group. Also, sand is accepted as a soil substitute, but doesn't create a sand tile.

Describe the solution

I simply made the numbers consistently 60 soil and removed the sand option in the recipes entirely.

Describe alternatives you've considered

Perhaps instead of simply removing the sand option from the construction a new construction to fill water with sand could be added.

Testing

I opened up a character and checked the construction menu for filling water with dirt. No sand as an option anymore and all soil requirements are identical in the recipes.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 8, 2022
The amount of soil should be the same across the board.

And sand isn't dirt, and shouldn't be substituted for it
@ashGlaw ashGlaw force-pushed the Audit-Fill-Water-with-Dirt-Constructions branch from 51477af to 6afe1bb Compare October 10, 2022 22:36
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 10, 2022
@Fris0uman Fris0uman merged commit fa069f8 into CleverRaven:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants