Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate weakpoint names and effects #61507

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Oct 6, 2022

Summary

None

Purpose of change

Fixes #60456

Describe the solution

Add translation lookups to code

Describe alternatives you've considered

Testing

Debug proficiencies, switch to non-english language (Japanese has weakpoint translations)
Spawn a few zombies, start hitting them, check message log doesn't get filled with english fallbacks

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 6, 2022
@irwiss irwiss force-pushed the translate-weakpoints branch from e58db35 to 45fe78e Compare October 6, 2022 21:11
@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Oct 6, 2022
@irwiss irwiss force-pushed the translate-weakpoints branch from 45fe78e to ee1d118 Compare October 6, 2022 22:09
@irwiss irwiss marked this pull request as ready for review October 6, 2022 22:28
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 6, 2022
@dseguin dseguin merged commit 2e49e16 into CleverRaven:master Oct 7, 2022
@irwiss irwiss deleted the translate-weakpoints branch October 7, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"name" and "message" of weakpoint is untranslated.
2 participants