MilComp repairs #61473
Merged
MilComp repairs #61473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Maleclypse
approved these changes
Oct 5, 2022
anothersimulacrum
approved these changes
Oct 5, 2022
Wrote it up on my phone, I'll test it today. |
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Makes MilComp item unrepairable"
Purpose of change
An oversight with making military composite plating unrepairable meant that it could be repaired by uninstalling it from the vehicle, repairing the item, and then reinstalling it on the vehicle. This A) should not work and B) is extremely tedious for the player taking advantage of it.
Describe the solution
Adds "NO_REPAIR" to the military composite item.
Describe alternatives you've considered
None.
Testing
Spawned item, confirmed it shows as not repairable.
Additional context
I understand the desire to repair military composite armor and the frustration it creates to not be able to do so. Realistically, the repair of such plating is to completely replace the piece of armor if it is damaged beyond a certain point, the piece is then recycled. Simple welds cannot restore the ceramic (which is what makes this composite) armor. It may be possible to create new ceramic sheets or at least a ceramic coating on metal armor, but those are extremely advanced processes and generally do not scale down to the creation of one single plate.