Removed long strings from piano disassembly and replaced the wires. #61371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Maleclypse
approved these changes
Oct 1, 2022
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
…leverRaven#61371) * remove strings and replace wire * wrong wire
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
…leverRaven#61371) * remove strings and replace wire * wrong wire
sparr
pushed a commit
to sparr/Cataclysm-DDA
that referenced
this pull request
Dec 10, 2022
…leverRaven#61371) * remove strings and replace wire * wrong wire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Pianos give tempered wire instead of regular wire & string upon disassembly"
Purpose of change
After bringing up that pianos are a good source of thread I was told that pianos do not use thread to play sounds, they use wire. After looking it up I found that they use a special type of "spring steel" wire which is made of tempered steel. Instead of making a new wire type I just used the tempered steel wire we have already, I figured it would make pianos a high value target for anyone looking for a quick way to get materials to blacksmith.
Describe the solution
removed the line in furniture_recreation.json that makes pianos drop long string, increased the number of wires dropped to compensate, and replaced the wire with qt_wire
Describe alternatives you've considered
Just making the piano give normal wire, or creating a new "piano wire" wire type.
Testing
N/A
Additional context
If there's any actual reason why the piano gives long string please let me know.