Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop liquid transfer from leaky tank before debugmsg #61184

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Sep 21, 2022

Summary

None

Purpose of change

Fixes #52647

Describe the solution

Stop liquid transfer before causing the debugmsg if transferring from leaky tank

Describe alternatives you've considered

Testing

Spawn 60L tank, 10L of gasoline, set item damage to 3000, install on vehicle it should be leaking, fill with gasoline, siphon back to jerrycan, should be no debugmsg after patch

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 21, 2022
@irwiss irwiss marked this pull request as ready for review September 21, 2022 18:07
@dseguin dseguin merged commit 1a6085e into CleverRaven:master Sep 22, 2022
@irwiss irwiss deleted the leaky-tank-debugmsg branch September 22, 2022 09:14
@irwiss irwiss restored the leaky-tank-debugmsg branch September 22, 2022 09:14
@irwiss irwiss deleted the leaky-tank-debugmsg branch September 22, 2022 09:14
@irwiss irwiss restored the leaky-tank-debugmsg branch September 22, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tried to drain something without any liquid
2 participants