Apply radiation health mod ONCE per day #61106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Radiation now penalizes daily health once per day, instead of once per turn"
Purpose of change
Currently, daily health is subtracting the player's radiation count every turn. This means that being exposed to even 1 radiation will drag daily health all the way down to -200 before it dissipates.
See also https://discord.com/channels/598523535169945603/598535827169083403/1021076432488779866 for some related discussion (development discord)
Describe the solution
Check for radiation only once a day
Describe alternatives you've considered
Testing
Compiled locally and debugged a new character with health and daily health +200, then gave them 200 radiation and checked their health every 30 minutes. Daily health gradually went down through the day (due to other modifiers) but only took a sharp 200 point drop once, on the next day. I waited another 24 hours and saw the same behavior.
Additional context
Thanks to @actually-a-cat for being better at reading C++ than I am