Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply radiation health mod ONCE per day #61106

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

RenechCDDA
Copy link
Member

Summary

Bugfixes "Radiation now penalizes daily health once per day, instead of once per turn"

Purpose of change

Currently, daily health is subtracting the player's radiation count every turn. This means that being exposed to even 1 radiation will drag daily health all the way down to -200 before it dissipates.

See also https://discord.com/channels/598523535169945603/598535827169083403/1021076432488779866 for some related discussion (development discord)

Describe the solution

Check for radiation only once a day

Describe alternatives you've considered

Testing

Compiled locally and debugged a new character with health and daily health +200, then gave them 200 radiation and checked their health every 30 minutes. Daily health gradually went down through the day (due to other modifiers) but only took a sharp 200 point drop once, on the next day. I waited another 24 hours and saw the same behavior.

Additional context

Thanks to @actually-a-cat for being better at reading C++ than I am

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 18, 2022
@dseguin dseguin merged commit eaba20f into CleverRaven:master Sep 18, 2022
@RenechCDDA RenechCDDA deleted the radiation_health_mod branch September 22, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants