Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to cancel rename the faction base name #61040

Merged

Conversation

EIIKaO
Copy link
Contributor

@EIIKaO EIIKaO commented Sep 16, 2022

Summary

None

Purpose of change

Enable you to cancel renaming faction base name.

Describe the solution

Added to the argument whether to force input.
basecamp::query_new_name( force = false )

Describe alternatives you've considered

None

Testing

  • Opening the base camp( cannot be cancelled as before )
  1. Get follower and go to the field together.
  2. Order that followe to open a base camp.
  3. Select any base camp style.
  4. Input popup appear.
  5. Confirm it cannot be cancelled.
  • Rename the base camp name( new feature )
  1. Press '#' key or open faction screen in some other way.
  2. Focus tab to "YOUR FACTION".
  3. Press 'enter' key, rename input box will popup.
  4. Do cancel( press 'esc' or to enter with empty text ).
  5. Confirm the base name not changed.

Additional context

I often press the enter key unexpectedly on the faction screen and more often can't remember the exact my base name, so the base name is sometimes slightly changed.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site json-styled JSON lint passed, label assigned by github actions labels Sep 16, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 16, 2022
@dseguin dseguin merged commit 5a867d1 into CleverRaven:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants