Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boots.json motorbike boots category change #61016

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

Dichards
Copy link
Contributor

@Dichards Dichards commented Sep 15, 2022

While morobike boots has better stats than steeltoed boots, it's now in armor category

Summary

Bugfixes "changed morocycle boots to fit in armor category"

Purpose of change

Steeltoed boots has less protection than motorcycle ones, but fits in armor category. I thought that motorcycle boots shoould be there too.

Describe the solution

Now motorcycle boots should categorised as armor

Describe alternatives you've considered

Or you can just remove steeltoed boots from armor category :P

Testing

Just spawn boots and see in inventory what category it placed

Additional context

While morobike boots has better stats than steeltoed boots, it's now in armor category
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing labels Sep 15, 2022
@GuardianDll
Copy link
Member

Pr is fine, but you need to change your summary to
Bugfixes "changed morocycle boots to fit in armor category"

@PatrikLundell
Copy link
Contributor

Or, alternatively, keep it as None and remove the quote section.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 15, 2022
@Dichards
Copy link
Contributor Author

changed to bugfixes

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 16, 2022
@bombasticSlacks bombasticSlacks merged commit 21c2f1f into CleverRaven:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants