Add an I4 diesel engine #60999
Merged
Add an I4 diesel engine #60999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
GM has at least one line of vehicles that uses this engine size in America so that should work. |
github-actions
bot
added
the
BasicBuildPassed
irwiss
reviewed
Sep 15, 2022
| { "x": -2, "y": 0, "parts": [ "frame_horizontal_rear", "hatch", "muffler" ] }, | ||
| { "x": -2, "y": 1, "parts": [ "frame_horizontal_rear", "hatch" ] }, | ||
| { "x": -2, "y": 2, "parts": [ "frame_se", "wheel_mount_medium", "wheel" ] }, | ||
| { "x": -2, "y": 2, "part": "tank_medium", "fuel": "gasoline" }, |
There was a problem hiding this comment.
Seems this needs a correction
There was a problem hiding this comment.
Oh I didn't even notice that car had two tanks, my bad.
I'll PR some fixes in a bit.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds an I4 diesel engine"
Purpose of change
Diesel engines only come in large sizes, making them way rarer than they should be.
In real life even common cars come with I4 diesel engines, so why wouldn't they in Cataclysm?
(At least that's the case here in Europe, if it's not the case in the US then I can close this PR)
Describe the solution
Adds the I4 diesel engine and adds it to item groups that have the I4 combustion engine.
Also added two variants of existing vehicles: Car and Hatchback in diesel flavor.
Describe alternatives you've considered
Not adding the cars, but if I recall correctly PRs that only add items without uses for them aren't accepted.
Testing
Spawned the vehicles and drove a little.
Additional context
I am not 100% certain on values chosen, so any feedback about them will be appreciated.
However I do hope this gets merged because I need those engines for a little forklift tweaks I'm planning.
I love forklifts.