Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant medical threshold from Resilient and Solidly Built #60965

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

actually-a-cat
Copy link
Contributor

Summary

None

Purpose of change

I replaced Medical tree's TOUGH and TOUGH2 mutations with alternative versions in #57611 but I left behind the threshold requirements on them. I don't think this causes any gameplay effects but it should be cleaned up. Because it shows up in HHG if nothing else.

Describe the solution

Removed them

Describe alternatives you've considered

Adding a consistency check to catch similar issues (I actually wrote one but it gets triggered by THRESH_MYCUS, what with the Mycus category not actually existing, and I don't really want to put in a special case exception)

Testing

Looked at the mutations in the debug mutate menu (it lists threshold reqs)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 13, 2022
@dseguin dseguin merged commit ff902ca into CleverRaven:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants