Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spill overflow/MIGRATION pockets from vehicle parts #60963

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Sep 13, 2022

Summary

None

Purpose of change

Fixes #56806

Describe the solution

Spill oversize items or migration pockets from vehicle part base items.

Also rewrite vehicle_part::consume_energy a bit to get rid of legacy_front.

Describe alternatives you've considered

Testing

Load save from linked issue, should drop plutonium cells on ground, the amount is a bit bonkers (10000) but that's what in the save json, probably result of plutonium slurry/cell migration.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions labels Sep 13, 2022
@irwiss irwiss changed the title Spill migration Spill overflow/MIGRATION pockets from vehicle parts Sep 13, 2022
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 13, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 13, 2022
@irwiss irwiss marked this pull request as ready for review September 13, 2022 22:06
@dseguin dseguin merged commit fe88739 into CleverRaven:master Sep 14, 2022
@irwiss irwiss deleted the spill-migration branch September 14, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash to desktop while trying to drive the vehicle
2 participants